Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 27, 2025

PR Description:
Adds additional test methods to MilvusFilterExpressionConverterTests to improve test coverage for the Milvus filter expression converter. Tests cover missing operators (NIN), edge cases (null values, empty strings, special characters), data types (long, float, boolean), list operations, complex expressions, and range queries.

Key additions:

  • List operations: testNin(), testEmptyList(), testSingleItemList(), testMixedTypesList()
  • Edge cases: testNullValue(), testEmptyString(), testZeroValues(), testVeryLongString()
  • Data types: testLongValue(), testFloatValue(), testBooleanFalse(), testNumericString()
  • Complex expressions: testTripleAnd(), testTripleOr(), testComplexOrWithMultipleFields(), testRangeQuery()
  • Key variations: testKeyWithDots(), testKeyWithSpecialCharacters(), testDoubleQuotedKey(), testSingleQuotedKey()

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Add a Signed-off-by line to each commit (git commit -s) per the DCO
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

@alxkm alxkm changed the title test: Add comprehensive test coverage for MilvusFilterExpressionConverter test: Add comprehensive test coverage for MilvusFilterExpressionConverter Aug 5, 2025
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko sobychacko merged commit a1e4dd5 into spring-projects:main Aug 6, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants